Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libre.fm in Now Playing #1651

Open
82d opened this issue Oct 26, 2021 · 5 comments · May be fixed by #2406
Open

add libre.fm in Now Playing #1651

82d opened this issue Oct 26, 2021 · 5 comments · May be fixed by #2406
Milestone

Comments

@82d
Copy link

82d commented Oct 26, 2021

Now Playing has ListenBrainz and Last.fm I think that you need to add libre.fm

@slook
Copy link
Member

slook commented Oct 26, 2021

I wonder how many more services will pop up in the future, it would be good to enable plugin developers to add services as desired, or perhaps even users if the API's URL format is exposed to a user preference. Currently, adding player services involves modifying the core see #1541

@82d
Copy link
Author

82d commented Oct 26, 2021

The API is the same as on the old one last.fm. the difference is that you need to enter the domain libre.fm http://turtle.libre.fm/, for this reason, in many applications, you can use the old plugin for last.fm, which went before when last.fm has changed its API.

@slook
Copy link
Member

slook commented Oct 26, 2021

This is interesting, do you know if these use the "RESTful" protocol standard? Perhaps it would provide more benefit to allow a custom URL text entry in the Preferences, rather than hard-coding the URL's.

@82d
Copy link
Author

82d commented Oct 26, 2021

This is interesting, do you know if these use the "RESTful" protocol standard? Perhaps it would provide more benefit to allow a custom URL text entry in the Preferences, rather than hard-coding the URL's.

you can see how this is done in the DeaDBeef last.fm scrobbler plugin

@mathiascode
Copy link
Member

I wonder if it would be time to finally bite the bullet, break backward compatibility and move the whole now playing feature (and the other now playing-related plugins) to a single pre-installed plugin. A rather unfortunate decision was made to use a single config option for the username/api key/command in all now playing providers, which complicates future additions to the current system. I'd also like to avoid code for external network services in the core, and the feature feels like something that belongs in a plugin.

@slook slook linked a pull request Feb 26, 2023 that will close this issue
8 tasks
@mathiascode mathiascode added this to the 3.4.0 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants