Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

TEMPLATE needs cleaning #139

Open
ewels opened this issue Mar 24, 2021 · 0 comments
Open

TEMPLATE needs cleaning #139

ewels opened this issue Mar 24, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@ewels
Copy link
Member

ewels commented Mar 24, 2021

Sorry about this, one last issue with your TEMPLATE branch..

Creating it in #92 did work and sure enough, you are now getting automated sync PRs such as #138

However, the TEMPLATE branch should only contain commits with the pure template and not any commits with a developed pipeline on it. Typically this means that there should only be a handful of commits on that branch (eg. rnaseq TEMPLATE has 13 commits). However it seems that your TEMPLATE has most of the development history in it with 1309 commits: https://github.com/nf-core/kmermaid/commits/TEMPLATE

This doesn't prevent the sync from working, but we discovered after a lot of trial and error that this makes the automated sync PRs super difficult to merge. Because git sees that you used to have the pipeline code in TEMPLATE and then deleted it to replace it with a vanilla nf-core create output it consistently wants to delete most of your pipeline in each sync PR - not great 😓

The solution is hopefully not too bad - assuming that your TEMPLATE branch commit history does go back far enough to have vanilla commits, we can just git reset --hard <sha> to that commit and then force push, wiping all of the commit history from the branch. Then we can re-do the nf-core sync to bring TEMPLATE up to date.

Once cleaned, this problem should hopefully not happen again. You can see in #138 that we changed the automated sync procedure to create a new branch each time and form a PR from that instead of directly from TEMPLATE. This means that you can fix the merge conflicts in that PR without pushing the dev history back into TEMPLATE.

I hope this makes sense, shout if you have any questions or would like some help 👍🏻

@ewels ewels added the bug Something isn't working label Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant