Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download link for windows in 8.2.4 doc #2743

Merged
merged 1 commit into from Feb 22, 2024
Merged

Fix download link for windows in 8.2.4 doc #2743

merged 1 commit into from Feb 22, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Feb 15, 2024

Should close #2742

@alkino alkino changed the base branch from master to release/8.2 February 15, 2024 17:36
@alkino
Copy link
Member Author

alkino commented Feb 15, 2024

We should fix the .exe.exe and be able to update the doc after the release @heerener

@alkino alkino marked this pull request as ready for review February 15, 2024 17:37
@alkino alkino changed the title Cornu/fix download link Fix download link for windows in 8.2.4 doc Feb 15, 2024
@alkino alkino requested a review from heerener February 15, 2024 17:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1413 New issues

Measures
143 Security Hotspots
No data about Coverage
10.4% Duplication on New Code

See analysis details on SonarCloud

heerener
heerener approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@heerener heerener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦
Thanks for noticing that!

@azure-pipelines Azure Pipelines
Copy link

✔️ ff59238 -> Azure artifacts URL

@pramodk pramodk merged commit d6c714c into release/8.2 Feb 22, 2024
16 checks passed
@pramodk pramodk deleted the cornu/fix_download_link branch February 22, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk approved these changes

@heerener heerener heerener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo for windows download url at https://nrn.readthedocs.io/en/8.2.4/
3 participants
@alkino @pramodk @heerener