Use build to create wheels
#2697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3.12, calling `python setup.py` to create wheels is deprecated; instead, one should use a "standard-based tool" (whatever that means), like the `build` package from PyPA. Therefore, instead of calling `setup.py bdist_wheel`, we use `python -m build`, which is the recommended replacement for it (as mentioned here: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary). Fixes #2696.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2697 +/- ##
==========================================
- Coverage 66.41% 66.41% -0.01%
==========================================
Files 558 558
Lines 108213 108214 +1
==========================================
- Hits 71874 71873 -1
- Misses 36339 36341 +2 ☔ View full report in Codecov by Sentry. |
|
|
Closing in favor of #2832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.12, calling
python setup.pyto create wheels is deprecated; instead, one should use a "standard-based tool" (whatever that means exactly), like thebuildpackage from PyPA.Therefore, instead of calling
setup.py bdist_wheel, we usepython -m build, which is the recommended replacement for it (as mentioned here: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary).Fixes #2696.
Note that we may need to pin version dependencies due to the comment listed here:
by adding a very minimal
pyproject.toml.EDIT: Seems we need to pass
--config-setting="--build-option=[OPTION]"to actually pass the options to the build system.EDIT 2: there's also
--config-setting="--global-option=[OPTION]"which puts all of the global options before the build ones, so this is a bit of a hack to silence the installer.