Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can *_net_send(void* be removed? #2682

Open
1uc opened this issue Jan 23, 2024 · 2 comments
Open

Can *_net_send(void* be removed? #2682

1uc opened this issue Jan 23, 2024 · 2 comments

Comments

@1uc
Copy link
Collaborator

1uc commented Jan 23, 2024

The following functions have been deprecated:

nrn/src/nrnoc/nrniv_mf.h

Lines 30 to 34 in d775050

[[deprecated("non-void* overloads are preferred")]] void artcell_net_send(void* v,
double* weight,
Point_process* pnt,
double td,
double flag);

nrn/src/nrnoc/nrniv_mf.h

Lines 36 to 40 in d775050

[[deprecated("non-void* overloads are preferred")]] void nrn_net_send(void* v,
double* weight,
Point_process* pnt,
double td,
double flag);

can they be removed in NRN 9.0?

@1uc 1uc changed the title Can *_net_{send,move}(void* be removed? Can *_net_send(void* be removed? Jan 23, 2024
@alkino
Copy link
Member

alkino commented Jan 23, 2024

Once all models have been fixed yes (means never I guess).

@pramodk
Copy link
Member

pramodk commented Jan 23, 2024

non-void* overloads are preferred
means never I guess

I don't want to say "never" because a similar situation will come soon for Random related topic. So we need to get this done.

I guess we need to see how many models are still using *_net_send(void* prototype and how much time/effort is to fix those. If not too much effort, we can update respective models, PR to ModelDB GitHub Org and we can remove this. The same thing that we have done for other breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants