model id is occasionally different from the id of the zip file #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another implementation method, that makes the existing modeldb API more visible, is to have the modeldb-meta.yaml file additionally contain the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEURON implementation identifiers are not always identical to model entry identifiers. For example, the entry identifier for
the 2005 Traub model is 45539 but the ifc fortran implementation is downloaded if that entry identifier is used for database download. This PR uses the NEURON implementation identifier instead of the entry identifier for
A wrinkle is that a model entry identifier may have multiple distinct NEURON implementation identifiers.
Closes #94
It may be worthwhile to modify this PR so that
data.Model._object_idcontinues to refer to the model entry identifier and add adata.Model._zip_idto refer to the id used for zip file download. Note that the ModelDB.metatdata dictionary now hasNEURON implementation identifiers for keys.
field to refer to the implementation identifier