Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie nette-samesite #182

Open
nargotik opened this issue Jun 12, 2020 · 6 comments
Open

Cookie nette-samesite #182

nargotik opened this issue Jun 12, 2020 · 6 comments

Comments

@nargotik
Copy link

Hi, as far i saw this cookie is set on src/Bridges/HttpDI/HttpExtension.php

There is any reason for this cookie to cannot be optional or name changed ?

@nargotik
Copy link
Author

Still not figure why this is this way .. and why cant the cookie be renamed.

@dg
Copy link
Member

dg commented Nov 10, 2020

Why do you want to rename it?

@nargotik
Copy link
Author

Because some projects don't need to say the visitors what technology they use, it makes part of security to don't pass information to visitors that provides crucial information about the system.

@nargotik
Copy link
Author

@dg What you think about it ?

@nargotik
Copy link
Author

nargotik commented Dec 7, 2020

Have added a PR with changes needed to add a new config variable: cookieNameStrict

PR: #189

@dg
Copy link
Member

dg commented Jan 5, 2021

At the moment, it is difficult to make a clean solution, so I'll implement it in the next bigger version.

However, in nette/http 3.1 the name has changed to _nss which is not so noticeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants