Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create autocompletion API for modules #68

Open
aufau opened this issue May 19, 2016 · 3 comments
Open

Create autocompletion API for modules #68

aufau opened this issue May 19, 2016 · 3 comments

Comments

@aufau
Copy link
Member

aufau commented May 19, 2016

Ability to autocomplete command arguments, eg. callvote or tell would be particularly useful (latter could probably go straight to JK2MV). Should we allow mods to override autocompletion functions defined by JK2MV?

I hope I can make it before next release, but I wouldn't make it a milestione as there are enough changes by now.

@aufau aufau self-assigned this May 19, 2016
@TriForceX
Copy link
Contributor

override the autocompletion functions should be optional for mods if this will be an api

@ouned
Copy link
Member

ouned commented May 19, 2016

i'd prevent mods from overriding engine cmds completely anyway

@Daggolin
Copy link
Member

I think it would be nice to offer some calls for mods to register own auto-complete functions (for commands like callvote), but I don't see a reason why a mod should be able to overwrite the auto-complete functions of engine-commands like map, bind or exec.

Auto-complete for tell doesn't really make sense in my opinion, cause basejk only accepts clientNums and you can't really auto-complete those. There are mods that allow the use of full or partial names when using the tell command, but having name-completion on basejk servers that don't support the use of tell with names is far more confusing for players than helping them. So I would prefer to leave auto-complete functions for mods up to mods.

@aufau aufau removed their assignment Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants