Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak in Styled Menus #22885

Open
NinjaNas opened this issue May 17, 2024 · 1 comment
Open

Memory Leak in Styled Menus #22885

NinjaNas opened this issue May 17, 2024 · 1 comment
Assignees
Labels
needs review The issue needs review to set priority, fix version or change status etc.

Comments

@NinjaNas
Copy link
Contributor

NinjaNas commented May 17, 2024

Issue type

Other type of issue

Bug description

By opening and closing any menu that uses StyleMenu, that memory is never released and could eventually crash.

Steps to reproduce

  1. Open task manager and check the memory usage for MS4
  2. Find a menu that uses StyledMenu, for example the file menu
  3. Repeatedly open and close that menu
  4. See that the memory usage for MS4 goes up and never goes back to normal levels

Screenshots/Screen recordings

2024-05-17.14-03-01.mp4

MuseScore Version

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.3.0-241231433, revision: github-musescore-musescore-5f36e74

Regression

I don't know

Operating system

Windows 10

Additional context

Relevant files may include:
src/appshell/view/navigableappmenumodel.cpp

src/appshell/qml/platform/AppMenuBar.qml
src/framework/uicomponents/qml/Muse/UiComponents/StyledMenuLoader.qml
src/framework/uicomponents/qml/Muse/UiComponents/internal/StyledMenu.qml

Possibly related to this issue as these menus can get stuck open:
#20417

Also, it was hidden in the video by the task manager but I was clicking this menu behind it
image

@muse-bot muse-bot added the needs review The issue needs review to set priority, fix version or change status etc. label May 17, 2024
@cbjeukendrup
Copy link
Contributor

Might be related to 2fa36e3: that commit may have fixed this, but sadly it had to be undone in #22681, because it caused big trouble (#22640, #22641)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The issue needs review to set priority, fix version or change status etc.
Projects
None yet
Development

No branches or pull requests

3 participants