Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reset" on property values doesn't work as expected #22835

Open
wizofaus opened this issue May 15, 2024 · 0 comments
Open

"Reset" on property values doesn't work as expected #22835

wizofaus opened this issue May 15, 2024 · 0 comments
Assignees
Labels
P1 Priority: High properties regression_ms3 Regression from MS3 (3.6.2) UX/interaction

Comments

@wizofaus
Copy link
Contributor

wizofaus commented May 15, 2024

Issue type

UX/Interaction bug (incorrect behaviour)

Bug description

If you've modified any property value for any element there's usually an option "Reset" (sometimes just an icon with an anti-clockwise circular arrow) that presumably means "I don't want this property to use a special value any more, it just should use the style default". But unfortunately that's not actually how it's implemented - it's implemented as "Change the value to whatever the specific style default value is currently", meaning that if you then change that style default value later, any property values you've changed then used "Reset" on do NOT update, despite the fact that other property values that have never been changed from the default DO update when the default is changed.

Steps to reproduce

  1. Create a new score
  2. Add 3 text elements
  3. For one of them, change a property value (e.g. frame type). Then click "reset" and confirm it changes back to the score default (usually no frame).
  4. Now edit another one of them, change the frame type to rectangular frame, then choose the option "save as default style for this score"
  5. Note that of the 3, two now show "rectangular" frame, but the one modified in step 3 does NOT.

Same behaviour if it's some style value you can change from the Format|Style dialog.

The problem is purely that "reset to default" isn't implemented as "delete the specific value set for this property, so that this property always takes the default value", rather as "change the specific value to whatever specific value is currently set as the default value".

Screenshots/Screen recordings

No response

MuseScore Version

4.3

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows 11

Additional context

No response

@muse-bot muse-bot added regression_ms3 Regression from MS3 (3.6.2) UX/interaction labels May 15, 2024
@bkunda bkunda added this to To do in 4.x SHORTLIST via automation May 17, 2024
@bkunda bkunda added the P1 Priority: High label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High properties regression_ms3 Regression from MS3 (3.6.2) UX/interaction
Projects
Status: One of the next releases
4.x SHORTLIST
  
To do
Development

No branches or pull requests

5 participants