Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU4 Issue] Change "Style" to "Line style" in Properties panel (for text-line, hairpin etc) #13562

Closed
rgreen5 opened this issue Oct 1, 2022 · 3 comments · Fixed by #22792
Closed

[MU4 Issue] Change "Style" to "Line style" in Properties panel (for text-line, hairpin etc) #13562

rgreen5 opened this issue Oct 1, 2022 · 3 comments · Fixed by #22792
Assignees
@EricManiez
Labels
community Issues we would like the community to address good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P4 Priority: Trivial strings Affects translatable strings
Projects
String change

Comments

@rgreen5
Copy link

rgreen5 commented Oct 1, 2022 •
edited

Describe the bug

For all kinds of lines there is a "Style" tab in the properties toolbar. There is often a property in this tab called "Style" which allows a selection of line styles. e.g.

hairpin_properties

However, IMV, "Style" should be relabelled "Line style", wherever it occurs in the panel, to avoid a clash both with the "Style" tab, and with the concept of "Style" generally in the program.
@Tantacrul Tantacrul added the community Issues we would like the community to address label Feb 22, 2023
@Tantacrul Tantacrul added this to Triage in String change via automation Feb 22, 2023
@Tantacrul Tantacrul added this to To do in 4.x LONGLIST via automation Feb 22, 2023
@Tantacrul Tantacrul added the P4 Priority: Trivial label Feb 22, 2023
@Tantacrul Tantacrul removed their assignment Feb 22, 2023
@hstanekovic
Copy link

hstanekovic commented Feb 22, 2023 •
edited

Or perhaps "Line pattern" instead of "Line style"

@cbjeukendrup cbjeukendrup added the strings Affects translatable strings label Aug 6, 2023
@cbjeukendrup cbjeukendrup added the good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute label Aug 27, 2023
@EricManiez
Copy link

I'll pick this one up if that's ok!

@EricManiez EricManiez mentioned this issue Aug 31, 2023
Closed
8 tasks
@cbjeukendrup
Copy link
Contributor

I realised that the linked PR has one potentially undesired side effect, namely that the same change would be applied for the Slurs and Ties inspector views. For a slur, "line style" sounds a bit unnatural to me, because it is not a line. @EricManiez perhaps we should avoid that, by allowing to override the title of LineStyleSection with some QML property. We'd make the default title "Line style", and override it in the SlurAndTieSettings to just "Style".

@cbjeukendrup cbjeukendrup moved this from Triage to In progress in String change Sep 8, 2023
@cbjeukendrup cbjeukendrup moved this from To do to In progress in 4.x LONGLIST Sep 10, 2023
@oktophonie oktophonie removed this from In progress in 4.x LONGLIST Oct 20, 2023
@BrownianNotion BrownianNotion mentioned this issue May 13, 2024
Merged
9 tasks
String change automation moved this from In progress to Done Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricManiez EricManiez

Labels
community Issues we would like the community to address good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P4 Priority: Trivial strings Affects translatable strings
Projects
Community Projects
Status: Done
MuseScore Studio 4.4
Status: Done
String change
  
Done
Milestone
No milestone
5 participants
@EricManiez @Tantacrul @cbjeukendrup @hstanekovic @rgreen5