Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer GET to POST #4480

Closed
GlazerMann opened this issue Apr 8, 2024 · 4 comments
Closed

Prefer GET to POST #4480

GlazerMann opened this issue Apr 8, 2024 · 4 comments

Comments

@GlazerMann
Copy link
Collaborator

proxy cachable

@GlazerMann
Copy link
Collaborator Author

Some APIs do not:
support GET
do not work with funky characters
do not work with large requests

So, test carefully

@maximmasiutin
Copy link
Contributor

let me add a condition for funky characters, it is probably the reason for "11β-Hydroxyprogesterone"

@maximmasiutin
Copy link
Contributor

let me add a condition for funky characters, it is probably the reason for "11β-Hydroxyprogesterone"

Sorry, didn't manage to implement it properly. Let me cancel my implementation attempt of changes of GET to POST for now, but let's keep in mind for the future to prefer GET wherever possible. By the way, since you changed all calls to curl, the use of citation bot via proxy works very well, with the only exception that it cannot cache requests made via POST; still even when I tried the code which didn't work well with funky characters, it worked very well if you consider the number of request saved by proxy (I used latest Squid for Linux).

@GlazerMann
Copy link
Collaborator Author

Closing an moving the wikipedia to-do list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants