-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 After pauseRecording()
, stopRecording()
takes 4 seconds longer than if not paused
#2732
Comments
pauseRecording()
, stopRecording()
takes 4 seconds longer than if not paused
yea, this is a bug. |
Any update on this? facing similar issue
|
No update yet, if you want me to fix this for ya, contact me thru my agency or sponsor this issue. |
Hey all! I just spent a few days on thinking about a battleproof timestamp synchronization solution, and I came up with a great idea.
This was really complex to built as I had to synchronize timestamps between capture sessions, and the entire thing is a producer model - a video buffer can come like a second or so later than the audio buffer, but I need to make sure the video track starts before the audio track starts, and ends after the audio track ends - that's a huge brainf*ck! 馃く馃槄 There's also no helper APIs for this on iOS, and it looks like no other Camera framework (not even native Swift/ObjC iOS Camera libraries) support this - they all break when timestamps have a delay (e.g. video stabilization enabled) (or dont even support delays at all) ; so I had to build the thing myself. Check out this PR and try if it fixes the issue for you; #2948 Thanks! 鉂わ笍 |
What's happening?
I logged every appendBuffer call at all if cases that are commented. While the video is recording we get a ton of
But our design calls for a pause function before saving. So we pause the video before calling stopRecording. When paused the buffer logs don't write cause the camera is paused. We have a button for the user to save and that calls stopRecording(). When that is called then these logs happen
On the react side the camera init looks like this
When the user pauses the recording we call
cameraRef.current.pauseRecording();
We then have buttons to save or retake the video. On save we call
cameraRef.current.stopRecording();
I think because it is in a pause state when we call stop no buffers are being called and that prevent finish() from happening as it normally would
Reproduceable Code
Relevant log output
Camera Device
Device
iPhone SE
VisionCamera Version
3.9.1
Can you reproduce this issue in the VisionCamera Example app?
No, I cannot reproduce the issue in the Example app
Additional information
The text was updated successfully, but these errors were encountered: