Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Django>=1.4, which added the "form_url" arg to ModelAdmin.change_view() #3

Open
abbottc opened this issue Jun 5, 2014 · 3 comments

Comments

@abbottc
Copy link

abbottc commented Jun 5, 2014

Django>=1.4 has added a new "form_url" arg to ModelAdmin, which means that the ErrorAdmin class in this project which overrides ModelAdmin needs a slight modification to still work. The "extra_context" variable passed to super() needs to be specified as a keyword argument, otherwise it erroneously becomes the "form_url" argument.

To clarify, the call to super() in ErrorAdmin.change_view() needs to be changed from this:
return super(ErrorAdmin, self).change_view(request, object_id, extra_context)
to this:
return super(ErrorAdmin, self).change_view(request, object_id, extra_context=extra_context)

@mridang
Copy link
Owner

mridang commented Jun 5, 2014

I'll make this fix ASAP. Thanks for the information @abbottc

@Zulan
Copy link

Zulan commented Aug 31, 2014

I just wanted to report the same issue. Hope you don't mind a little bump.

@sgs00
Copy link

sgs00 commented Oct 13, 2014

Fixed - #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants