Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--no-title-bar mode the title bar appears after toggling fullscreen and window-maximized #14126

Open
verygoodlee opened this issue May 12, 2024 · 4 comments · May be fixed by #14127
Open

--no-title-bar mode the title bar appears after toggling fullscreen and window-maximized #14126

verygoodlee opened this issue May 12, 2024 · 4 comments · May be fixed by #14127
Assignees
@kasper93
Labels
os:win

Comments

@verygoodlee
Copy link

verygoodlee commented May 12, 2024 •
edited

Important Information

Provide following Information:

  • mpv version
mpv v0.38.0-209-g38741452 Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on May 12 2024 00:09:14
libplacebo version: v7.349.0 (v6.338.0-130-gbf1855c-dirty)
FFmpeg version: N-115182-g0d9591841
FFmpeg library versions:
   libavutil       59.17.100
   libavcodec      61.5.103
   libavformat     61.3.103
   libswscale      8.2.100
   libavfilter     10.2.101
   libswresample   5.2.100
  • Windows Version
Win11 23H2 22631.3527

Reproduction steps

  • input.conf
f osd-msg cycle fullscreen
x osd-msg cycle window-maximized
  • run mpv "any.mp4" --no-title-bar --no-input-default-bindings --pause=yes --autofit-larger=50%x50% --log-file=log.txt
  • cycle fullscreen to yes
  • cycle window-maximized to yes
  • cycle fullscreen to no

Expected behavior

N/A

Actual behavior

a small title bar appears.
the left right and bottom borders disappears.
the rounded window corner changes to right angle window corner.
屏幕截图 2024-05-12 210248

Log file

log.txt

Sample files

N/A
@kasper93 kasper93 self-assigned this May 12, 2024
@kasper93
Copy link
Contributor

kasper93 commented May 12, 2024 •
edited

I have a fix for that on my local branch, that's why I didn't see that.

Fixed by #14127 you can try build from there

kasper93 added a commit to kasper93/mpv that referenced this issue May 12, 2024
@kasper93
win32: fix resizing window when maximized
a318efe 
This remembers and sets window-scale when exiting maximized state. Also
fixes not staying in maximized state when exiting fullscreen mode.

Fixes: mpv-player#14126
@kasper93 kasper93 linked a pull request May 12, 2024 that will close this issue
Draft
@verygoodlee
Copy link
Author

verygoodlee commented May 12, 2024 •
edited

Fixed by #14127 you can try build from there

it works.

kasper93 added a commit to kasper93/mpv that referenced this issue May 12, 2024
@kasper93
win32: fix window size restore after maximize state
b4b558b 
This remembers and sets window-scale when exiting maximized state. Also
fixes not staying in maximized state when exiting fullscreen mode.

Fixes: mpv-player#14126
kasper93 added a commit to kasper93/mpv that referenced this issue May 12, 2024
@kasper93
win32: fix window size restore after maximize state
ceebf81 
This remembers and sets window-scale when exiting maximized state. Also
fixes not staying in maximized state when exiting fullscreen mode.

Fixes: mpv-player#14126
@senorYME
Copy link

same title bar is missing for me, on garuda distro

@llyyr
Copy link
Contributor

llyyr commented May 16, 2024

same title bar is missing for me, on garuda distro

open a new issue, this one is for windows and almost definitely completely unrelated to yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasper93 kasper93

Labels
os:win
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

win32: fix resizing window when maximized kasper93/mpv
4 participants
@kasper93 @llyyr @verygoodlee @senorYME