Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adr: address suggestions have wrong district #496

Open
jbruechert opened this issue Apr 28, 2024 · 2 comments
Open

adr: address suggestions have wrong district #496

jbruechert opened this issue Apr 28, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jbruechert
Copy link
Contributor

Arnimalee 14 is definitely in Berlin (as the marker correctly shows), but is considered part of Potsdam-Mittelmark

image

@felixguendling
Copy link
Member

felixguendling commented Apr 28, 2024

Yes, the problem is that we're currently using bounding boxes. If an address has for a specific level only one bounding box overlapping it, we take this as the truth and don't calculate with the exact admin_level area shapes. This is only done if we have multiple bounding boxes overlapping the address. So in this case since Berlin doesn't have level 8 admin_areas, we just use the one from Potsdam-Mittelmark. So fixing this would require us to do the exact check for area overlaps everywhere which will significantly slow down the import. But probably that's the way to go.

/*
This is an example Overpass query.
Try it out by pressing the Run button above!
You can find more examples with the Load tool.
*/
rel
  ["admin_level"="8"]
  ({{bbox}});
/*end of auto repair*/
/*added by auto repair*/
(._;>;);
/*end of auto repair*/
out;

image

@felixguendling
Copy link
Member

image

Relation: Potsdam-Mittelmark (62353)

@felixguendling felixguendling added the bug Something isn't working label May 9, 2024
@felixguendling felixguendling self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants