-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Clang "direct access in function foo() to global weak symbol bar" warnings in MeshOptimizer and TinyGltfConverter plugins #551
Comments
Hmm, tried to reproduce here on Linux with clang, libc++ and
... this is apparently due to a My CI build reports a similar problem in the MeshOptimizerSceneConverter plugin, so I'll look into this problem instead and maybe if I find a fix for it, it'll fix the TinyGltfImporter issue as well.
Actually, yes, it was -- there's a completely new plugin, CgltfImporter, which is based on cgltf. Compared to tiny_gltf it compiles way faster as there's no humongous modern C++ JSON parser library behind, it doesn't use the STL containers so it's way more memory efficient, and it also parses everything way faster. All effort now goes into this new plugin, If you switch to this plugin, you should no longer get those warnings as the 3rd party code is way simpler and better. Nevertheless, I'm keeping the issue open until I make the build warning-free again. |
See github action run: https://github.com/TheOpenSpaceProgram/osp-magnum/runs/5082185747
This is happening on Mac OS X, which for my project is not a platform we really care about, but we do run a Mac OS X CI just for the heck of it.
I haven't noticed this problem on other platforms.
Happening with commit 3102678 , let me know if work was done in this area since and i can try a newer commit.
The text was updated successfully, but these errors were encountered: