Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize track URLs before logging? #2051

Open
adamcik opened this issue May 31, 2022 · 0 comments
Open

Sanitize track URLs before logging? #2051

adamcik opened this issue May 31, 2022 · 0 comments
Labels
A-core Area: Core layer C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal

Comments

@adamcik
Copy link
Member

adamcik commented May 31, 2022

mopidy/mopidy-spotify#110 (comment) made me realize that we should probably strip out any auth info in URLs we log. I don't think we can ensure that plugins don't screw this up, but we should probably make sure core does it's part. One option that comes to mind is having a dedicated type that also does this sanitation when __str__ is used on it, forcing the cases where we want to true value to call some other method.

@kingosticks kingosticks added C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal A-core Area: Core layer labels Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core layer C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal
Projects
None yet
Development

No branches or pull requests

2 participants