Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with newer versions of torch #81

Open
Dom303 opened this issue Apr 27, 2020 · 6 comments
Open

Make compatible with newer versions of torch #81

Dom303 opened this issue Apr 27, 2020 · 6 comments

Comments

@Dom303
Copy link

Dom303 commented Apr 27, 2020

When installing moses via pip, it overwrites the local pytorch version. Please, change the code to pip install tensorflow-gpu>=1.14 , and make sure it is compatible with newer versions.

pip install tensorflow-gpu==1.14

@danpol
Copy link
Collaborator

danpol commented Apr 27, 2020

@SeemonJ, can you please comment on this?

@SeemonJ
Copy link
Contributor

SeemonJ commented Apr 28, 2020

Hi @Dom303,

The reason why we are using specifically tensorflow-gpu 1.14 is because it is the last version that supports the loading of the pretrained models and weights for the heteroencoder in the LatentGAN. I do not recall if the newer branch of the heteroencoder, intended for tensorflow 2.0 use, is compatible with the LatentGAN and allowing us to train new models, but the immediate problem is that it would render reproducibility impossible.

@Dom303
Copy link
Author

Dom303 commented Apr 28, 2020

Sorry, I referenced Tensorflow by accident, I wanted to reference Pytorch v1.1.0. Can you add support for PyTorch 1.4 or 1.5?

&& conda install -yq -c pytorch pytorch=1.1.0 torchvision=0.2.1 \

@danpol
Copy link
Collaborator

danpol commented May 6, 2020

Hi, @Dom303! If you install MOSES using pip (pip install molsets), the requirement is torch>=1.1.0 — it should not affect your local version of PyTorch. We specify a fixed (older) version in Docker for reproducibility.

@Hunter-Leo
Copy link

Hunter-Leo commented Dec 4, 2020

Hi, @SeemonJ ! I was temp to retrain the Latent-GAN with my own data on the Moses platform, but it seems not quite an easy job to settle the dependencies right. I set the environment and installed dependencies just as the steps listed in the 'Manually' section, but the procedure still reported lots of warnings and errors(May still caused by version compatible problem).
Need your help baddddly!!
图片
图片

Updated after 2h:
It's fine now. I reproduced it with the source code of Latent-GAN, and set up with the Deep-Drug-Code (Moses branch). Peace!

@SeemonJ
Copy link
Contributor

SeemonJ commented Dec 6, 2020

@Hunter-Leo
Good to hear that you have solved the issue. I would, however, advise you to try to start with a fresh heteroencoder model rather than the moses-pretrained model, if you have a training set that has different structures than the moses molecules. You do this easiest by adding the option
--heteroencoder_version new

the default of latentgan is to use the pretained model in the directory to save time, which might not always be the most suitable for your task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants