FEAT-#7265: Automatic publication of Modin wheel to PyPI #7262
Conversation
anmyachev
changed the title
anmyachev
force-pushed
the
auto-publish-wheel
branch
from
1b93e19
to
830a735
Compare
anmyachev
changed the title
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
force-pushed
the
auto-publish-wheel
branch
from
486a41a
to
3ebe973
Compare
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
Co-authored-by: Devin Petersohn <devin.petersohn@snowflake.com>
| path: ./dist/ | ||
|
|
||
| - name: Publish Modin wheel to PyPI | ||
| if: startsWith(github.ref, 'refs/tags') |
There was a problem hiding this comment.
We likely want to run the entire job on a new tag. Let's lift this up.
There was a problem hiding this comment.
+1 left a comment above for how to do this.
There was a problem hiding this comment.
I will leave this if statement as additional safeguard against accidental changes if you don't mind.
There was a problem hiding this comment.
I looked at how this was done in Pandas and Numpy, everywhere it is possible to launch through workflow_dispatch event or according to a schedule to make sure that everything works correctly. For such checks to work, we need to remove triggering only for tags.
There was a problem hiding this comment.
It should work to add workflow_dispatch under on: if we want to also manually trigger it. Multiple options can be put in the on setting
There was a problem hiding this comment.
I added events: workflow_dispatch and schedule.
There was a problem hiding this comment.
I suggest we only upload when the trigger is a push, rather than looking at the ref.
| if: startsWith(github.ref, 'refs/tags') | |
| if: github.event_name == "push" |
| path: ./dist/ | ||
|
|
||
| - name: Publish Modin wheel to PyPI | ||
| if: startsWith(github.ref, 'refs/tags') |
There was a problem hiding this comment.
+1 left a comment above for how to do this.
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
We should checkout Modin with fetch_depth: 0, otherwise only a latest commit is fetched.
There was a problem hiding this comment.
We should have tagged wheels, otherwise we might get untagged ones.
There was a problem hiding this comment.
It is possible the latest commit is not the tagged commit, so I think @YarShev is correct. Additionally, we may want to check out the latest tag to ensure we only upload tagged releases.
It would be good to also have a check that ensures that the release name is correct, so it doesn't upload a bad release.
There was a problem hiding this comment.
Will it be better to use fetch-tags: option?
There was a problem hiding this comment.
Yes that would be good, but we should also git checkout the latest tag to ensure we build the correct release. It seems like we still need fetch-depth:0 for fetch-tags to work properly: actions/checkout#1471
Co-authored-by: Devin Petersohn <devin-petersohn@users.noreply.github.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
| on: | ||
| schedule: | ||
| - cron: "42 0 * * WED" | ||
| push: |
There was a problem hiding this comment.
I think this got deleted somewhere. We need it so that this triggers for every new tag.
| push: | |
| push: | |
| tags: | |
| - '*' |
| path: ./dist/ | ||
|
|
||
| - name: Publish Modin wheel to PyPI | ||
| if: startsWith(github.ref, 'refs/tags') |
There was a problem hiding this comment.
I suggest we only upload when the trigger is a push, rather than looking at the ref.
| if: startsWith(github.ref, 'refs/tags') | |
| if: github.event_name == "push" |
| with: | ||
| fetch-depth: 0 | ||
| fetch-tags: true | ||
| - name: Set up Python |
There was a problem hiding this comment.
We need to check out the latest tag because that might not be where head is (for point releases and if new commits are merged after the tag)
| - name: Set up Python | |
| - name: Checkout latest git tag | |
| - if: github.event_name == "push" | |
| git checkout $(git describe --tags "$(git rev-list --tags --max-count=1)") | |
| - name: Set up Python |
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date