Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lists internal_by, not_broadcastable_by are closure captured in query_compiler.groupby_agg #7119

Open
arunjose696 opened this issue Mar 25, 2024 · 0 comments
Open

lists internal_by, not_broadcastable_by are closure captured in query_compiler.groupby_agg #7119

arunjose696 opened this issue Mar 25, 2024 · 0 comments
Labels
Internals Internal modin functionality Performance 🚀 Performance related issues and pull requests.

Comments

@arunjose696
Copy link
Collaborator

Anti-pattern: Closure capturing large objects harms performance.

In query_compiler.groupby_agg operations, the lists internal_by,not_broadcastable_by are closure captured, this closure capturing could be removed to follow the ray design pattern.

Note:This isssue is a subtask of #5524
@anmyachev anmyachev added Performance 🚀 Performance related issues and pull requests. Internals Internal modin functionality labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internals Internal modin functionality Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arunjose696 @anmyachev