Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or spread *args and **kwargs in BaseIO methods #7108

Open
mvashishtha opened this issue Mar 19, 2024 · 1 comment
Open

Remove or spread *args and **kwargs in BaseIO methods #7108

mvashishtha opened this issue Mar 19, 2024 · 1 comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase Interfaces and abstractions Issues with Modin's QueryCompiler, Algebra, or BaseIO objects P3 Very minor bugs, or features we can hopefully add some day.

Comments

@mvashishtha
Copy link
Collaborator

mvashishtha commented Mar 19, 2024

Some BaseIO methods like read_parquet have only **kwargs as their arguments when they should specify particular required arguments. Others, like read_csv, include **kwargs but should not. We should clean up the BaseIO interface so that it only allows parameters that are appropriate for each method.

See also the related issue for the query compiler, #3108.

@mvashishtha mvashishtha added Code Quality 💯 Improvements or issues to improve quality of codebase P3 Very minor bugs, or features we can hopefully add some day. Enable plugin Fixes needed to enable external plugins Interfaces and abstractions Issues with Modin's QueryCompiler, Algebra, or BaseIO objects and removed Enable plugin Fixes needed to enable external plugins labels Mar 19, 2024
@anmyachev
Copy link
Collaborator

The consequence of this will be a complication of code support (the amount of work to keep signatures up to date will at least double), since function signatures will be defined in full not only at the top level, but also at the level of query compilers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase Interfaces and abstractions Issues with Modin's QueryCompiler, Algebra, or BaseIO objects P3 Very minor bugs, or features we can hopefully add some day.
Projects
None yet
Development

No branches or pull requests

2 participants