Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop app: replace context-menu by dropdowns #1370

Closed
255kb opened this issue Apr 28, 2024 · 0 comments · Fixed by #1399
Closed

Desktop app: replace context-menu by dropdowns #1370

255kb opened this issue Apr 28, 2024 · 0 comments · Fixed by #1399
Assignees
Labels
App: Desktop Issue is for the desktop app

Comments

@255kb
Copy link
Member

255kb commented Apr 28, 2024

Problem

Some features and options are inside right click context menus, in the environments, routes, data buckets or callbacks menus.
This is not ideal for accessibility and feature discoverability.

Solution

Replace by regular dropdowns:

image

Optional: keep the right click to display this dropdown at the mouse cursor position. But this seems to be a pain to implement with ng-bootstrap and popper.js options.

@255kb 255kb added the App: Desktop Issue is for the desktop app label Apr 28, 2024
@255kb 255kb changed the title Dekstop app: replace context-menu by dropdowns Desktop app: replace context-menu by dropdowns Apr 28, 2024
@255kb 255kb self-assigned this May 27, 2024
255kb added a commit that referenced this issue May 29, 2024
- Create new dropdown component
- use it everywhere there is a context menu
- add a context menu on the logs entries
- harmonize the menus look and feel
- make the data bucket id clickable and copy to clipboard
Closes #1370
255kb added a commit that referenced this issue May 30, 2024
- Create new dropdown component
- use it everywhere there is a context menu
- add a context menu on the logs entries
- harmonize the menus look and feel
- make the data bucket id clickable and copy to clipboard
Closes #1370

Fix tests

Rename context menu

Fix wrong selector in test

Fix test selector
255kb added a commit that referenced this issue May 31, 2024
* Replace context menus by dropdown

- Create new dropdown component
- use it everywhere there is a context menu
- add a context menu on the logs entries
- harmonize the menus look and feel
- make the data bucket id clickable and copy to clipboard
Closes #1370

* Toggle all direct children from folder #1188 (#1323)
* All disabling routes by folder name in CLI and serverless

---------

Co-authored-by: Santiago Caro Duque <santiagocaroduque@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: Desktop Issue is for the desktop app
Projects
Status: Done (merged, ready for next release)
Development

Successfully merging a pull request may close this issue.

1 participant