You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's a minor detail, but the docstrings for functions like mne.read_epochs_eeglab() and mne.read_epochs_kit() indicate that an Epochs instance is returned, while in reality they return subclasses of BaseEpochs; specifically EpochsEEGLAB and EpochsKIT, respectively.
It can be deceptive, for example it could encourage the use of a isinstance(epochs, mne.Epoch) because although BaseEpoch exists, the documentation could misleads into thinking that there is only one type of Epoch class.
Even though there don't seem to be any html pages created for these subclasses that could be linked, i think we could add a few details to be clearer, what do you think ?
The text was updated successfully, but these errors were encountered:
Proposed documentation enhancement
It's a minor detail, but the docstrings for functions like mne.read_epochs_eeglab() and mne.read_epochs_kit() indicate that an Epochs instance is returned, while in reality they return subclasses of
BaseEpochs
; specificallyEpochsEEGLAB
andEpochsKIT
, respectively.It can be deceptive, for example it could encourage the use of a
isinstance(epochs, mne.Epoch)
because althoughBaseEpoch
exists, the documentation could misleads into thinking that there is only one type ofEpoch
class.Even though there don't seem to be any html pages created for these subclasses that could be linked, i think we could add a few details to be clearer, what do you think ?
The text was updated successfully, but these errors were encountered: