Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: don't refer to functoria documentation #1512

Closed
Tracked by #1536
reynir opened this issue Mar 24, 2024 · 2 comments · Fixed by #1537
Closed
Tracked by #1536

Documentation: don't refer to functoria documentation #1512

reynir opened this issue Mar 24, 2024 · 2 comments · Fixed by #1537

Comments

@reynir
Copy link
Member

reynir commented Mar 24, 2024

From time to time I look up documentation using either Merlin or ocp-browser, and a few values such as Mirage.package says e.g. "Same as Functoria.Package.v". This is rather annoying as in both Merlin and ocp-indent there are no hyperlinks to get to the actual documentation.

Another one is Mirage.impl that defines itself as of_device @@ Device.v where Mirage doesn't even have a Device module.

Somewhat motivated by mirage/mirage-skeleton#388.

@samoht
Copy link
Member

samoht commented Mar 24, 2024

Yea, that's a very good point. I'm trying to fix those when I see those references, but it would be nice to have a more systematic review of those references.

@hannesm hannesm mentioned this issue May 16, 2024
14 tasks
hannesm added a commit to hannesm/mirage that referenced this issue May 16, 2024
@hannesm
Copy link
Member

hannesm commented May 16, 2024

I addressed the observed issues in #1537, happy to get a review.

hannesm added a commit to hannesm/opam-repository that referenced this issue May 17, 2024
CHANGES:

- BREAKING: remove `~name` parameter from Mirage.Runtime_args.create
  (mirage/mirage#1541 @samoht, fixes mirage/mirage#1532)
- BREAKING: remove `~name` parameter from Mirage.runtime_arg, and use a
  string (instead of a format string) as third parameter (mirage/mirage#1541 @samoht)
- constrain the `start` function to `unit Lwt.t`. Previously, there was no
  restrictions, and lots of time was spent in debugging when a unikernel
  resulted in `unit Lwt.t Lwt.t` (@Julow mirage/mirage#1524)
- revise man page sections and ordering: ARGUMENTS, OPTIONAL, NETWORK OPTIONS,
  DISK OPTIONS, LOG AND MONITORING OPTIONS, OCAML RUNTIME OPTIONS. Previously,
  the ARGUMENTS and OPTIONS were put later, and were hard to find. These are
  the sections where unikernel-specific arguments are put by default
  (mirage/mirage#1531 @hannesm @reynir)
- add --net=host and --net=ocaml to reduce confusion. --net=host uses the
  TCP/IP socket stack, --net=ocaml the OCaml network stack (mirage/mirage#1525 @hannesm)
- quote Runtime_arg.call (mirage/mirage#1522 @Julow)
- documentation fixes (inline examples @Julow mirage/mirage#1523, @hannesm mirage/mirage#1537 (fixes
  mirage/mirage#1512 reported by @reynir), Runtime_args.create mirage/mirage#1541 @samoht)
- fix the build instructions of the generated opam file: since 4.5.0
  `mirage build` is no longer available, use `make "build"` (mirage/mirage#1527 @hannesm)
- add RELEASE.md, a guide on how to cut a mirage release (mirage/mirage#1519 @samoht)
- allow git 3.16 (mirage/mirage#1536 @hannesm)
- use mirage-bootvar (using dune variant) instead of parse-argv and
  mirage-bootvar-xen, mirage-bootvar-solo5, mirage-bootvar-unix
  (mirage/mirage#1533 @hannesm)
- BUGFIX: reset the lexer location before applying functors in generated code
  (mirage/mirage#1539 @samoht, fixes mirage/mirage#1520 @hannesm)
- BUGFIX: fix off-by-one locations for mirage/main.ml (mirage/mirage#1540 @samoht, fixes
  mirage/mirage#1528 @hannesm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants