Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the unit of virials❓ [QUESTION] #404

Open
YuanbinLiu opened this issue Jan 31, 2024 · 3 comments
Open

What is the unit of virials❓ [QUESTION] #404

YuanbinLiu opened this issue Jan 31, 2024 · 3 comments
Labels
question Further information is requested

Comments

@YuanbinLiu
Copy link

I'd like to train virials as well. Could you point out what unit is used for the virial fitting?

@YuanbinLiu YuanbinLiu added the question Further information is requested label Jan 31, 2024
@Linux-cpp-lisp
Copy link
Collaborator

What do you mean by "as well"? There is no reason to train virials and stresses simultaneously as they are fully redundant.

@YuanbinLiu
Copy link
Author

YuanbinLiu commented Jan 31, 2024

Sorry for the unclear description. I want to train on energy, forces, and virials (not stresses). I need to know which unit I have to use for fitting virials so that I can adjust them to the suitable format. Could it be GPa or eV? @Linux-cpp-lisp

@Linux-cpp-lisp
Copy link
Collaborator

Aha, I see: we do not do any unit conversions for either virials or stress, since nequip has no formal sense of units and just inherits the units of the dataset. So presumably eV in this case.

See for some more details comments throughout: https://github.com/mir-group/nequip/blob/develop/nequip/nn/_grad_output.py#L346-L351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants