Inventory: Quickly picking up item and placing it again no longer works #14233
Comments
Wuzzy2
added
the
Unconfirmed bug
grorp
added
Bug
|
Yes, grorp. Oops. |
|
@OgelGames any chance you could look at this? |
|
I don't get what the issue is, clicking twice quickly is double-clicking, so it activates the pick-up-all shortcut. The shortcut behavior shouldn't change depending on how many items there are, that's like expecting |
|
I just checked and the double-click speed/delay setting in your OS does effect this, reducing the delay should fix it. (note that you need to restart Minetest when you change it) |
|
This is a design flaw then. It is extremely irritating to me that if you pick up a single item, and want to put it back immediately again (maybe because of a misclick), it no longer works. If this is the intended behavior, I argue the intention is flawed. The problem is that sometimes, clicking with a single item on an empty slot will NOT work. The problem that even if this behavior is intentional, it feels like a bug. Also, why is the OS-level setting relevant at all here? If I just reduce the double-click speed, then I also lose the "pick up all" feature. |
|
There is no bug, either you click slow enough for two separate clicks, or you click fast enough for a double-click. The OS setting is relevant because that is what determines the point at which two clicks are counted as a double-click. See here, it does work: 2024-02-19.23-00-39.mp4 |
|
I think it would make sense to ignore the double-click and just allow putting the item back when the double-click doesn't pick up any additional items. The problem here (or the bug, whatever) is that the double-click doesn't do anything visible to the user in some cases, but it still prevents putting the item back. While this might make sense if you know why it happens, the unknowing user will think they can't put the item back for no reason at all.
In your video, you didn't show the described problem case (no items left to pick up by double-click, quickly picking up item and trying to put it back). |
|
@OgelGames: You did it wrong. Please follow the exact steps to reproduce. The inventory must be emptied first. Don't add new items. |
2024-02-20.19-03-26.mp4Still works fine ¯\_(ツ)_/¯ |
Minetest version
Active renderer
No response
Irrlicht device
No response
Operating system and version
GNU/Linux
CPU model
No response
GPU model
No response
OpenGL version
No response
Summary
If you click on an item stack in the inventory and click again, sometimes you only pick up the item stack but won't place it back.
This is a regression because previously, this would have placed back the item.
I think this bug might have been caused with the new inventory shortcuts added to 5.8.0. Specifically, there is a new feature that will put all the items of the same kind in the inventory towards your cursor if you doubleclick it. Normally, this is very useful but what if the item you doubleclicked was the only one in the inventory? Then your item stack does not change and you do not put it back as well (which you would expect).
This is very irritating because the player will think that clicking in the inventory is sometimes broken. I think the proper bugfix would be to always put the item back after a double click it this no additional item was added to the cursor.
@OgelGames
Steps to reproduce
Expected behavior: You quickly pick up the item stack with the first click and place it back with the 2nd click.
Actual behavior: You only pick up the item stack, so it appears to the player that clicking in the inventory is sometimes randomly broken.
The text was updated successfully, but these errors were encountered: