Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better AppStream metadata #14648

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Better AppStream metadata #14648

wants to merge 4 commits into from

Conversation

AFCMS
Copy link
Contributor

@AFCMS AFCMS commented May 13, 2024 •
edited

Fix #14647

To do

This PR is Ready for Review

  • Rename .appdata.xml to .metainfo.xml (.metainfo.xml is the recommended file name)
  • Import description translations from .desktop
  • Translate long description in french
  • Fix typo in french .desktop description
  • Use HTTPS URLs for screenshots
  • Add support info for mouse, keyboard, gamepad and touch
  • Add support info for supported screen size
  • Add support info for offline use
  • Use the launchable tag to reference the .desktop file, remove .desktop from the top id (no idea why it was like that, didn't see it anywhere in the spec)
  • Add category and keywords
  • Add basic developer infos (is it OK?)
  • Fix URLs for bugtracker and donation
  • Make first paragraph of long description longer? (>80 characters) Not a big deal IMO.

How to test

Try running:

flatpak run --command=flatpak-builder-lint org.flatpak.Builder appstream ./misc/net.minetest.minetest.metainfo.xml

or this (less strict):

appstreamcli validate ./misc/net.minetest.minetest.metainfo.xml

Warning

With the renaming of the AppStream file, the Flathub manifest will need to be updated to reflect the change I think

sfan5
sfan5 reviewed May 13, 2024
View reviewed changes
misc/net.minetest.minetest.metainfo.xml

<translation type="gettext">minetest</translation>

<update_contact>sfan5@live.de</update_contact>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use this opportunity to put someone else's email here.
Volunteers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Minetest mailing list (for core devs?) would be convenient for such cases.

@AFCMS
Copy link
Contributor Author

AFCMS commented May 13, 2024

I have added a value to display_length.

The goal is to make it appear as supported for both PC and mobile devices, so I picked 360 which is the value used by GNOME Calculator.

I have also added a tag to display the offline use of Minetest possible.

@wsor4035 wsor4035 added @ Startup / Config / Util @ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels May 13, 2024
@Zughy Zughy added Action / change needed Code still needs changes (PR) / more information requested (Issues) labels May 13, 2024
@AFCMS AFCMS requested a review from rubenwardy May 14, 2024 07:05
@AFCMS AFCMS mentioned this pull request May 14, 2024
Draft
2 tasks
@Zughy Zughy removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label May 14, 2024
@AFCMS
Copy link
Contributor Author

AFCMS commented May 14, 2024

I consider this PR as finished, IMO the last TODO item isn't really important.

The last thing to check is the contact email, but don't know what to put here obviously.

@sfan5
Copy link
Member

sfan5 commented May 20, 2024

ruben and c55 are also listed here: https://github.com/minetest/minetest/security/policy
So one of them would be a good candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 left review comments

@SmallJoker SmallJoker SmallJoker left review comments

@rubenwardy rubenwardy Awaiting requested review from rubenwardy

Assignees
No one assigned
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements @ Startup / Config / Util
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Appstream metadata
6 participants
@AFCMS @sfan5 @SmallJoker @rubenwardy @wsor4035 @Zughy