Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some sounds no longer work in 5.9.0-dev #14453

Closed
ryvnf opened this issue Mar 11, 2024 · 5 comments · Fixed by #14529
Closed

Some sounds no longer work in 5.9.0-dev #14453

ryvnf opened this issue Mar 11, 2024 · 5 comments · Fixed by #14529
Labels
Bug Issues that were confirmed to be a bug @ Client / Audiovisuals Regression Something that used to work no longer does. Sounds
Milestone
5.9.0

Comments

@ryvnf
Copy link
Contributor

ryvnf commented Mar 11, 2024 •
edited

Minetest version

Where it does not work

Minetest 5.9.0-dev-fbec37886 (Linux)
Using Irrlicht 1.9.0mt15
Using LuaJIT 2.1.0-beta3
Built by GCC 12.2
Running on Linux/6.1.0-10-amd64 x86_64
BUILD_TYPE=Release
RUN_IN_PLACE=0
USE_CURL=1
USE_GETTEXT=1
USE_SOUND=1
STATIC_SHAREDIR="/usr/local/share/minetest"
STATIC_LOCALEDIR="/usr/local/share/locale"

Irrlicht device

X11

Operating system and version

Debian 6.1.38-2

CPU model

No response

GPU model

No response

Active renderer

No response

Summary

In Mineclonia I noticed that the sound mcl_sounds_place_node_water.ogg no longer works on my Minetest version. It works in 5.6.0.

Steps to reproduce

  1. Install Mineclonia (if not having it already)
  2. Create a world and go into creative mode.
  3. Give yourself a water bucket and place nodes
  4. Notice that no sound is placed when placing water nodes

Optional: Try the same on earlier Minetest version – works on 5.6.0.
@ryvnf ryvnf added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Mar 11, 2024
@SmallJoker
Copy link
Member 

2024-03-11 19:18:05: WARNING[OpenALSoundManager]: Audio: Error decoding mcl_sounds_place_node_water.ogg
2024-03-11 19:18:05: WARNING[OpenALSoundManager]: SoundDataOpenBuffer: Failed to load sound "mcl_sounds_place_node_water.ogg"

games/mineclonia$ find . -type f -name "mcl_sounds_place_node_water.*"
./mods/CORE/mcl_sounds/sounds/mcl_sounds_place_node_water.ogg

mcl_sounds is loaded according to /mods. With rough bisecting I can tell that this issue was introduced before 2024-01-21 (latest RUN_IN_PLACE=1 where I have a matching IrrlichtMt .so).

@SmallJoker SmallJoker added Bug Issues that were confirmed to be a bug @ Client / Audiovisuals and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Mar 11, 2024
@appgurueu appgurueu added the Regression Something that used to work no longer does. label Mar 11, 2024
@metmj
Copy link

metmj commented Mar 11, 2024

@SmallJoker I have same warning at Minetest 5.8.0 from ubuntu (5.8.0-ppa0~ubuntu22.04.1), but works good when I use 5.6.1 from debian (5.6.1+dfsg+~1.9.0mt8+dfsg-2).

@Desour
Copy link
Member

Desour commented Mar 11, 2024

Link to the file, so you can add it to your devtest/mods/soundstuff/sounds/gitignored_sounds:
https://codeberg.org/mineclonia/mineclonia/src/branch/main/mods/CORE/mcl_sounds/sounds/mcl_sounds_place_node_water.ogg

Can reproduce.

@Desour
Copy link
Member

Desour commented Mar 11, 2024 •
edited

I've done a little debugging (43dbebd).
Apparently ov_pcm_total says the sound is 101504 samples long (203008 bytes, because we use s16), but it ends already after 202112 bytes ov_read skips some samples. Idk why this can happen.

@Desour Desour added the Sounds label Mar 11, 2024
@sfan5 sfan5 added this to the 5.9.0 milestone Apr 5, 2024
@Desour Desour mentioned this issue Apr 9, 2024
Merged
@Desour
Copy link
Member

Desour commented Apr 9, 2024 •
edited

@ryvnf Would you like to test #14529, maybe with more sounds if you have some? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues that were confirmed to be a bug @ Client / Audiovisuals Regression Something that used to work no longer does. Sounds
Projects
None yet
Milestone
5.9.0
6 participants
@sfan5 @SmallJoker @Desour @ryvnf @appgurueu @metmj