Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: CompactionExecutor use a pool #33182

Open
1 task done
xiaofan-luan opened this issue May 20, 2024 · 3 comments
Open
1 task done

[Enhancement]: CompactionExecutor use a pool #33182

xiaofan-luan opened this issue May 20, 2024 · 3 comments
Assignees
@atris
Labels
good first issue Good for newcomers kind/enhancement Issues or changes related to enhancement

Comments

@xiaofan-luan
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Currently, the compaction is running wit goroutine with unlimited memory.

// These two func are bounded for waitGroup
func (c *compactionExecutor) executeWithState(task compactor) {
go c.executeTask(task)
}

Use a pool could save memory and also reduce resource contention.

Why is this needed?

No response

Anything else?

No response
@xiaofan-luan xiaofan-luan added kind/enhancement Issues or changes related to enhancement good first issue Good for newcomers labels May 20, 2024
@atris
Copy link

atris commented May 21, 2024

Can I please take this issue up?

@xiaofan-luan
Copy link
Contributor Author

/assign @atris
let me know if you need any help

@forsaken628 forsaken628 mentioned this issue Jun 3, 2024
Merged
@forsaken628
Copy link
Contributor

forsaken628 commented Jun 5, 2024 •
edited

Please take a look. @xiaofan-luan
#33558

sre-ci-robot pushed a commit that referenced this issue Jun 11, 2024
@forsaken628
enhance: add a semaphore for CompactionExecutor (#33558)
6b9901c 
#33182

---------

Signed-off-by: coldWater <254244460@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atris atris

Labels
good first issue Good for newcomers kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atris @forsaken628 @xiaofan-luan