Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Microsoft.Office.SubjectInterfacePackages version 16.0.16507.43425 #152521

Conversation

vikingnope
Copy link
Contributor

@vikingnope vikingnope commented May 7, 2024

Pull request has been created with komac v2.2.1 🚀

Resolves: #152520

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 7, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented May 7, 2024

Hi @vikingnope,

This package has an unusual install flow:

  • Portable exe is actually installer file - running it prompts for license agreement:
    image
    • Then an installer location:
      image
    • The installer switch /? gave:
      image
  • After that installer completes, the installed EXE has a dependency:
    image

The /quiet switch performs the nested install without user interaction (/passive leaves a messagebox to click "OK"). And the nested installer needs a Custom switch with /extract:C:\path\to\extraction\location, or the installer will silently fail (or maybe install to an unknown location?)

The dependency is on Microsoft.VCRedist.2015+.x64, except this is an x86 application, so could use Microsoft.VCRedist.2015+.x86. Or probably should have both architectures declared, with the architecture-specific dependency.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label May 7, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed New-Package labels May 7, 2024
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 7, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels May 7, 2024
@stephengillie
Copy link
Collaborator

Should this have a different or more clear PackageIdentifier? My brain expands the acronym "SIP" into "Session Initiation Protocol" so I keep thinking this is a VOIP function for MS Office.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vikingnope vikingnope changed the title New package: Microsoft.OfficeSIP version 16.0.16507.43425 New package: Microsoft.Office.SubjectInterfacePackages version 16.0.16507.43425 May 7, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels May 7, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented May 7, 2024

Automatic Validation ended with:

Executable C:\WinGetInstallerRoot\Microsoft.Office.SubjectInterfacePackages\offclearsig.exe returned exit code: -1073741515

Automated error analysis suggests -1073741515 may mean Dependency on Microsoft.VCRedist.2015+.x64 (or .x86).

(Automated response - build 880.)

Edit: This updated manifest doesn't seem to install the dependency.
image

Note on the package manager side - if there's a space in the path, it silently doesn't install and still gives exit code 0. (Didn't chech with quotes.)
image

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error New-Package labels May 8, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 8, 2024
@vikingnope
Copy link
Contributor Author

vikingnope commented May 8, 2024

I think it was the wrong dependency package, I think it should be correct now.

EDIT: I removed x64 again since the dependency we have now only has a 32-bit version

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed New-Package labels May 8, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 8, 2024
@vikingnope
Copy link
Contributor Author

@stephengillie, can you recheck this please?

@stephengillie
Copy link
Collaborator

This is unchanged.

This updated manifest doesn't seem to install the dependency.
image

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label May 9, 2024
@vikingnope vikingnope closed this May 9, 2024
@vikingnope vikingnope deleted the Microsoft.OfficeSIP-16.0.16507.43425-8FA35D1E4020405BBB73E1DF604378A7 branch May 9, 2024 15:39
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. New-Package Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: Microsoft Office Subject Interface Packages for Digitally Signing VBA Projects
4 participants