Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer use Command.Name for disambiguation #17166

Open
PankajBhojwani opened this issue May 1, 2024 · 0 comments
Open

No longer use Command.Name for disambiguation #17166

PankajBhojwani opened this issue May 1, 2024 · 0 comments
Assignees
@PankajBhojwani
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.22

Comments

@PankajBhojwani
Copy link
Contributor

Description of the new feature/enhancement

Once #17162 merges, we will have unique ActionIDs for command disambiguation. This means we no longer need to use Command.Name for disambiguation and should update the following accordingly: Command, ActionMap, SettingsEditor, CommandPalette

Proposed technical implementation details (optional)

Any location where we use Command.Name to disambiguate commands we should be using their IDs instead
@PankajBhojwani PankajBhojwani added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels May 1, 2024
@PankajBhojwani PankajBhojwani self-assigned this May 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 1, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 1, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.22 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.22
Development

No branches or pull requests
2 participants
@carlos-zamora @PankajBhojwani