Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent margins on color schemes settings page #16290

Open
chausner opened this issue Nov 11, 2023 · 1 comment · May be fixed by #16291
Open

Inconsistent margins on color schemes settings page #16290

chausner opened this issue Nov 11, 2023 · 1 comment · May be fixed by #16291
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@chausner
Copy link
Contributor

Windows Terminal version

1.18.2822.0

Windows build number

10.0.22635.0

Other Software

No response

Steps to reproduce

Open the color scheme settings page.

Expected Behavior

No response

Actual Behavior

The left margins of the disclaimer text "Schemes defined here...", the "Add new" button and the ListView below are too small and do not line up with the page header "Color schemes". On other settings pages, the controls line up properly.

image
@chausner chausner added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 11, 2023
@chausner
Copy link
Contributor Author

Submitted a MR with a proposed fix: #16291

@chausner chausner linked a pull request Nov 11, 2023 that will close this issue
Draft
4 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Nov 11, 2023
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 15, 2023
@carlos-zamora carlos-zamora added this to the Backlog milestone Nov 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Nov 15, 2023
@carlos-zamora carlos-zamora added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Area-Settings UI Anything specific to the SUI and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix margins on color schemes settings page chausner/terminal
2 participants
@carlos-zamora @chausner