Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: FunctionCallContent and FunctionResultContent should have plugin_name and function_name #6258

Closed
matthewbolanos opened this issue May 14, 2024 · 2 comments · Fixed by #6286
Closed

Python: FunctionCallContent and FunctionResultContent should have plugin_name and function_name #6258

matthewbolanos opened this issue May 14, 2024 · 2 comments · Fixed by #6286
Labels
python Pull requests for the Python Semantic Kernel triage

Comments

@matthewbolanos
Copy link
Member

Today, each class only has name. name should be split out into its component parts
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel triage labels May 14, 2024
@eavanvalkenburg
Copy link
Member

we did that through methods in python, .split_name and .split_name_dict, we could create properties from there to mitigate, would that work?

@matthewbolanos
Copy link
Member Author

Yes, that'd be great

@eavanvalkenburg eavanvalkenburg mentioned this issue May 16, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue May 16, 2024
@eavanvalkenburg
Python: added function_name and plugin_name properties to FC and FCR (#…
a5a38b8 
…6286)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Fixes #6258

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
bochris pushed a commit to bochris/semantic-kernel that referenced this issue May 16, 2024
@eavanvalkenburg @bochris
Python: added function_name and plugin_name properties to FC and FCR (m…
3606755 
…icrosoft#6286)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Fixes microsoft#6258

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python: added function_name and plugin_name properties to FC and FCR eavanvalkenburg/semantic-kernel
3 participants
@matthewbolanos @eavanvalkenburg @markwallace-microsoft