-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net : memoryPlugin["Save"] inserting NULL value at first position (SQLite) #6249
Comments
The issue seems to be caused by how the does collection exist functionality is implemented. The connector stores all data in a single table, so the way it determines whether a collection exists or not is if there is a row there with a matching collection column value. On collection creation a null record with the collection name is inserted if there are no records with the required collection name yet. This null record gets removed whenever There are a number of issues with this:
We have a few options here:
3 would be a breaking change for existing users. 1 would be a behavioral breaking change for existing users. 2 or 4 is therefore least disruptive. |
@westey-m |
@atiq-bs23, is the null record causing you problems, or are you just curious about why it's there? |
@westey-m it's not causing any issue in my end |
Describe the bug
await kernel.InvokeAsync(memoryPlugin["Save"], new() { [Microsoft.SemanticKernel.Plugins.Memory.TextMemoryPlugin.InputParam] = "My family is from New York", [Microsoft.SemanticKernel.Plugins.Memory.TextMemoryPlugin.CollectionParam] = MemoryCollectionName, [Microsoft.SemanticKernel.Plugins.Memory.TextMemoryPlugin.KeyParam] = "info5", });
After executing this method, it is inserting a row with NULL value for the first time. I am using SQLite
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should insert a single row with the value pass to this method, but it is adding another row with NULL value.
Screenshots
Platform
Microsoft.SemanticKernel.Plugins.Memory -> Version=1.6.3-alpha]
The text was updated successfully, but these errors were encountered: