Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

make output transform unpad and scale down mask in penobscot metrics - facilitates correctly reported inline mIoU #276

Open
maxkazmsft opened this issue Apr 20, 2020 · 0 comments
Labels
Prior: Medium Type: Accuracy related to increasing performance accuracy Type: Enhancement This an enhancement to an existing feature

Comments

@maxkazmsft
Copy link
Contributor

maxkazmsft commented Apr 20, 2020

Address the following TODO in interpretation/deepseismic_interpretation/penobscot/metrics.py

# TODO: make output transform unpad and scale down mask
# scale up y_pred and remove padding
class InlineMeanIoU(Metric):

In the same class, in update method, add assertion to cover the dimensionality of max_prediction variable

        # TODO: Make assertion exception
        # issue: https://github.com/microsoft/seismic-deeplearning/issues/276
        max_prediction = y_pred.max(1)[1].squeeze()
@maxkazmsft maxkazmsft added Prior: High Type: Correctness anything to do with repo being technically correct labels Apr 20, 2020
@maxkazmsft maxkazmsft added this to the Ver 1.0 milestone Apr 20, 2020
@maxkazmsft maxkazmsft added this to Mn: Backlog in Manganese Apr 20, 2020
@maxkazmsft maxkazmsft added Type: Enhancement This an enhancement to an existing feature and removed Type: Correctness anything to do with repo being technically correct labels Jun 5, 2020
@maxkazmsft maxkazmsft added Type: Accuracy related to increasing performance accuracy Prior: Medium and removed Prior: High labels Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Prior: Medium Type: Accuracy related to increasing performance accuracy Type: Enhancement This an enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant