Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create issues to track remaining host component properties that we need to implement for fabric #13183

Open
8 tasks
jonthysell opened this issue May 3, 2024 · 0 comments
Assignees
Labels
API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Deliverable Major item tracked for top-level planning in ADO enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: React Native RNW does not look or behave like upstream RN platforms
Milestone

Comments

@jonthysell
Copy link
Contributor

There are a variety of new issues tracking the remaining work to implement host component properties that we had in RNW paper and want to keep having in fabric. However the source list may have been out of date, and explicitly didn't include properties that RNW paper didn't already have.

We need a list of remaining properties that exist in fabric upstream and are not implemented in RNW fabric. From that list we can use a script to open tracking issues in RNW for each missing property.

Note: we may still choose to not implement a given property in RNW fabric, but it's better to have that decision captured in a closed issue that can be re-opened later.

See also the old tracking issues here for properties that we ignored for Paper: #11135

Tasks

Strategy

  1. For each of the host components, look through their API page on reactnative.dev for the total list of supported properties expected
  2. Determine whether the property works or not in RNW fabric. Strategies include:
    1. Checking the existing old parity lists for host component parity (Host Components in RNW have parity between Paper and Fabric renderers #11135)
    2. Searching the RNW fabric code (usually under vnext/Microsoft.ReactNative/Fabric`
    3. Search the RN JS code (the property may be JS-only and not something we actually need to implement anything for
    4. Explicitly try using the property in test apps (e2e-test-app-fabric or otherwise)
  3. Keep track of the properties that don't work in RNW fabric in a spreadsheet, including: Component Name, Property Name, Direct URL to Property in the RN Docs, and any Notes about what you discovered

After we have the lists, we can automate opening tracking items for each with the proper labels, etc.

@jonthysell jonthysell added API: Completion Deliverable Major item tracked for top-level planning in ADO Area: Fabric Support Facebook Fabric Area: Component Views New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: React Native RNW does not look or behave like upstream RN platforms labels May 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 3, 2024
@jonthysell jonthysell changed the title Create issues to track host component properties that we need to implement for fabric Create issues to track remaining host component properties that we need to implement for fabric May 3, 2024
@chrisglein chrisglein added this to the Next milestone May 6, 2024
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label May 7, 2024
@chrisglein chrisglein added enhancement and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Deliverable Major item tracked for top-level planning in ADO enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: React Native RNW does not look or behave like upstream RN platforms
Projects
Status: No status
Development

No branches or pull requests

3 participants