Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf2c should support bpf2bpf function calls #3388

Open
dthaler opened this issue Mar 25, 2024 · 3 comments · May be fixed by #3506
Open

bpf2c should support bpf2bpf function calls #3388

dthaler opened this issue Mar 25, 2024 · 3 comments · May be fixed by #3506
Assignees
@dthaler
Labels
blocked Blocked on another issue that must be done first enhancement New feature or request triaged Discussed in a triage meeting
Milestone
Backlog

Comments

@dthaler
Copy link
Collaborator

dthaler commented Mar 25, 2024 •
edited

Describe the feature you'd like supported

currently bpf2c only supports inlined function calls, not bpf2bpf function calls.
PREVAIL is adding support for non-inlined function calls, and bpf2c should do the same.

Proposed solution

Generate function calls when the bpf bytecode uses the call local instruction

Additional context

No response
@dthaler dthaler added the enhancement New feature or request label Mar 25, 2024
@shankarseal
Copy link
Collaborator

The verifier changes are covered by vbpf/ebpf-verifier#608 in the verifier repo. We need to make a similar change in bpf2c tool.

@shankarseal shankarseal added the triaged Discussed in a triage meeting label Apr 1, 2024
@shankarseal
Copy link
Collaborator

@dthaler are you OK with backlogging this? We will revisit this in the next week's triage.

@shankarseal shankarseal removed the triaged Discussed in a triage meeting label Apr 1, 2024
@dthaler dthaler self-assigned this Apr 2, 2024
@dthaler dthaler added this to the 2404 milestone Apr 2, 2024
@dahavey dahavey added the triaged Discussed in a triage meeting label Apr 8, 2024
@dthaler dthaler added the blocked Blocked on another issue that must be done first label Apr 15, 2024
@dthaler
Copy link
Collaborator Author

dthaler commented Apr 15, 2024

Blocked on vbpf/ebpf-verifier#608 being merged

@dthaler dthaler linked a pull request Apr 28, 2024 that will close this issue
Open
@dthaler dthaler modified the milestones: 2404, 2405 Apr 29, 2024
@shankarseal shankarseal modified the milestones: 2405, Backlog May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dthaler dthaler

Labels
blocked Blocked on another issue that must be done first enhancement New feature or request triaged Discussed in a triage meeting
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

add bpf2c support for non-inlined local function calls dthaler/ebpf-for-windows
3 participants
@dthaler @dahavey @shankarseal