Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive card flow for QuickStart Playground doesn't appear to be displaying error states? #2964

Open
adrastogi opened this issue May 17, 2024 · 1 comment
Assignees
Labels
Area-Quickstart Issue-Bug Something isn't working or needs investigation Priority-2

Comments

@adrastogi
Copy link
Contributor

Dev Home version

0.1401.501.0

Windows build number

10.0.22631.3593

Other software

OS Build Version: 10.0.22631.3593.amd64fre.ni_release.220506-1250
.NET Version: .NET 8.0.4

Steps to reproduce the bug

I was trying to manually simulate some errors in the Azure extension where I had the dependency UI controller generate an exception that I expected the Quickstart feature code to handle.

Expected result

I think we should be showing the propagated exception data as an adaptive card? (I need to look closer at the implementation to confirm.)

Actual result

There doesn't appear to be any information provided back to the user about the exception.

Included System Information

No response

Included Extensions Information

Extensions:
Microsoft.Windows.DevHome_0.1301.477.0_x64__8wekyb3d8bbwe (Dev Home (Preview))
Microsoft.Windows.DevHome_0.1301.477.0_x64__8wekyb3d8bbwe (Dev Home (Preview))
Microsoft.Windows.DevHomeGitHubExtension_0.1300.477.0_x64__8wekyb3d8bbwe (Dev Home GitHub Extension (Preview))
Microsoft.Windows.DevHomeGitHubExtension.Canary_0.1400.500.0_x64__8wekyb3d8bbwe (Dev Home GitHub Extension (Canary))
Microsoft.Windows.DevHome.Canary_0.1401.501.0_x64__8wekyb3d8bbwe (Core Widget Extension)
Microsoft.Windows.DevHome.Canary_0.1401.501.0_x64__8wekyb3d8bbwe (Hyper-V Extension)
Microsoft.Windows.DevHomeAzureExtension.Canary_0.900.501.0_x64__8wekyb3d8bbwe (Dev Home Azure Extension (Canary))
Microsoft.Windows.DevHomeAzureExtension.Dev_0.0.0.0_x64__8wekyb3d8bbwe (Dev Home Azure Extension (Dev))
Microsoft.Windows.DevHome.Dev_0.0.0.0_x64__8wekyb3d8bbwe (Core Widget Extension)
Microsoft.Windows.DevHome.Dev_0.0.0.0_x64__8wekyb3d8bbwe (Hyper-V Extension)

Widget Service:
MicrosoftWindows.Client.WebExperience_524.12200.10.0_x64__cw5n1h2txyewy

@adrastogi adrastogi added the Issue-Bug Something isn't working or needs investigation label May 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label May 17, 2024
@adrastogi adrastogi self-assigned this May 17, 2024
@adrastogi
Copy link
Contributor Author

adrastogi commented May 18, 2024

There are a few things going on here:

  • If the QuickstartAdaptiveCardResult corresponds to a failure, we currently bail out without showing anything, so we should consider what we'd want to report here (e.g., ContentDialog with the error info)
  • The result has limited information in it, which relates back to the exception Dev Home receives (e.g., Message is an empty string)

Image

[22:29:52 ERR] CreateAdaptiveCardSessionForExtensionInitialization for: QuickStartProject provider: Dev Container using OpenAI failed due to exception
System.Runtime.InteropServices.COMException (0x80131620)
   at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0(Int32 hr)
   at ABI.Microsoft.Windows.DevHome.SDK.IQuickStartProjectProviderMethods.CreateAdaptiveCardSessionForExtensionInitialization(IObjectReference _obj)
   at ABI.Microsoft.Windows.DevHome.SDK.IQuickStartProjectProvider.global::Microsoft.Windows.DevHome.SDK.IQuickStartProjectProvider.CreateAdaptiveCardSessionForExtensionInitialization()
   at DevHome.SetupFlow.Models.QuickStartProjectProvider.CreateAdaptiveCardSessionForExtensionInitialization()

@adrastogi adrastogi added Priority-2 and removed Needs-Triage New issue that the core contributors need to triage labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Quickstart Issue-Bug Something isn't working or needs investigation Priority-2
Projects
None yet
Development

No branches or pull requests

1 participant