Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS440100 - False Positive #545

Open
7flying opened this issue May 30, 2023 · 3 comments
Open

DS440100 - False Positive #545

7flying opened this issue May 30, 2023 · 3 comments
Assignees
Labels
false positive rule Something associated with the rules (not code related)

Comments

@7flying
Copy link

7flying commented May 30, 2023

Rule ID

DS440100

What the rule matched

https://github.com/fedora-iot/fido-device-onboard-rs/blob/e94c588277a8310d0ba25424708bd2df06097a12/admin-tool/src/aio/configure.rs#L46-L47

https://github.com/fedora-iot/fido-device-onboard-rs/blob/e94c588277a8310d0ba25424708bd2df06097a12/admin-tool/src/aio/configure.rs#L272-L272

Why should this not be matched?

It is the name of a struct field in Rust.

@7flying 7flying changed the title [False Positive] DS440100 - False Positive May 30, 2023
@gfs
Copy link
Contributor

gfs commented May 31, 2023

Thanks for the report. We are still working on updates to the rules and I'll add this to that effort.

@gfs gfs added the rule Something associated with the rules (not code related) label May 31, 2023
@atrompler
Copy link
Contributor

This one looks tricky to resolve, the original regex is not very sophisticated in how it's looking for ciphers. May need to significantly refactor this one.

@gfs
Copy link
Contributor

gfs commented Jul 31, 2023

@atrompler I think this rule is too generic. It may need to be refactored to look for the specific constants for the curve name in each language rather than the generic curve names in general - it could then use a word separator around the declared constants to ensure that its not conincidentally part of some other variable declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false positive rule Something associated with the rules (not code related)
Projects
None yet
Development

No branches or pull requests

3 participants