Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace /ack API with proposals #6189

Open
eddyashton opened this issue May 17, 2024 · 1 comment
Open

Replace /ack API with proposals #6189

eddyashton opened this issue May 17, 2024 · 1 comment

Comments

@eddyashton
Copy link
Member

We believe the existing /ack paths can be removed, and instead done in the proposal flow. Roughly:

  • Remove any consideration of member activeness from the C++ code
  • Add a new ack action, which requires no votes and always passes resolve, and updates the member's state to Active
  • When tallying votes in the default resolve() function, only count members if they are Active

We could also make submit any proposal an implicit ack, so that the proposer doesn't need to submit an ack action directly.
This reduces the API surface, and allows services to opt out of the ACK behaviour entirely if they wish, by removing it from their constitutions.

@achamayou
Copy link
Member

Note: we need to update propose to allow proposals from inactive members.

Also note: the reason ack() can be empty is because the proposal id includes the root of the merkle tree, and is effectively equivalent to the pre-existing, explicit ack endorsement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants