Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-ups for redirection support #6082

Open
5 of 6 tasks
eddyashton opened this issue Mar 21, 2024 · 0 comments
Open
5 of 6 tasks

Follow-ups for redirection support #6082

eddyashton opened this issue Mar 21, 2024 · 0 comments
Assignees
Labels

Comments

@eddyashton
Copy link
Member

eddyashton commented Mar 21, 2024

#6050 provides a working implementation of forwarding, but there's a few things that I've delayed for future PRs:

  • Removing the custom is_create flag. I think the special /create endpoint can be given appropriate flags so that it is always executed locally, and doesn't need a custom flag. Remove is_create_request flag #6096
  • Revisit fallback to local execution. This was added to the redirection path for parity with the forwarding path. I believe hope it can be removed, but we may currently depend on it during unit tests or early-lifecycle execution. Move unnecessary compatibility path #6097
  • Clarify interaction of set_forwarding_required and set_redirection_strategy. We currently derive the latter from the former, need to make sure we do that safely, as we move towards deprecation of the former.
  • Improve documentation. The auto-generated host schema docs don't give much detail on the new fields, need to expand what they show. Update RST docs generation from JSON schema #6095
  • Add to_backup forwarding option. No explicit demand for this, but should be easy to add for balance.
  • Add sample of JS app configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant