New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`:double` generates Long if `:min` is Long #1034

Closed

frenchy64 opened this issue Apr 9, 2024 · 0 comments · Fixed by #1052

Contributor

frenchy64 commented Apr 9, 2024

I think this is a quirk of gen/double-gen*. Perhaps we could throw here or coerce the bounds to Double.

(defn shrink [?schema]
  (-> (quick-check 1 (for-all [s (mg/generator ?schema)] false) {:seed 0})
      :shrunk
      :smallest
      first))

((juxt class identity) (shrink [:double {:min 3}]))
;=> [java.lang.Long 3]

The text was updated successfully, but these errors were encountered:

frenchy64 added a commit to frenchy64/malli that referenced this issue


          Coerce :double bounds to double

73ed511

Close metosin#1034

frenchy64 mentioned this issue

Coerce :double bounds to double #1052

Merged

frenchy64 added a commit to frenchy64/malli that referenced this issue


          Coerce :double bounds to double

64ac86e

Close metosin#1034

ikitommi closed this as completed in #1052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment