Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] [Bug] Cannot combine compatible timeseries metrics in dashboards #42575

Closed
Tracked by #37335
ranquild opened this issue May 13, 2024 · 0 comments · Fixed by #42970
Closed
Tracked by #37335

[BE] [Bug] Cannot combine compatible timeseries metrics in dashboards #42575

ranquild opened this issue May 13, 2024 · 0 comments · Fixed by #42970
Assignees

Comments

@ranquild
Copy link
Contributor

ranquild commented May 13, 2024

Reproduce:

  • New -> Question -> Orders, Sum by Count, Group by Created At -> Save as "Orders over time question"
  • Create the same metric -> "Orders over time metric"
  • Create a similar question and a metric but based on Products
  • Create a new dashboard and add "Orders over time question" and "Orders over time metric".
  • Click Edit -> Add series.
  • It's possible to add "Products over time question" to "Orders over time question", but not with metrics

Expected result:

  • It should be possible to combine metrics just as saved questions in dashboards. Please note that combining scalar metrics works.

Bug:

  • /api/card/:id/series does not return metrics. It relies on the visualization_settings present, which is not the case for metrics. This is currently by design.
  • The BE should rely on the query when there is no corresponding viz setting. If there is no graph.metrics setting, assume that all last-stage aggregations are used. No graph.dimensions -> use breakouts.
Screenshot 2024-05-13 at 09 54 03

Question:
Screenshot 2024-05-13 at 09 53 59

Metric:
Screenshot 2024-05-13 at 09 54 11

@ranquild ranquild changed the title [BE] [QP] [Bug] Cannot combine compatible metrics in dashboards [FE] [Bug] Cannot combine compatible metrics in dashboards May 13, 2024
@ranquild ranquild changed the title [FE] [Bug] Cannot combine compatible metrics in dashboards [FE/BE] [Bug] Cannot combine compatible metrics in dashboards May 13, 2024
@ranquild ranquild changed the title [FE/BE] [Bug] Cannot combine compatible metrics in dashboards [BE] [Bug] Cannot combine compatible metrics in dashboards May 13, 2024
@ranquild ranquild changed the title [BE] [Bug] Cannot combine compatible metrics in dashboards [BE] [Bug] Cannot combine compatible timeseries metrics in dashboards May 13, 2024
snoe added a commit that referenced this issue May 21, 2024
Fixes #42575

The BE should rely on the query when there is no corresponding viz setting.

If there is no graph.metrics setting, assume that all last-stage aggregations are used. No graph.dimensions -> use breakouts.
snoe added a commit that referenced this issue May 21, 2024
Fixes #42575

The BE should rely on the query when there is no corresponding viz setting.
If there is no graph.metrics setting, assume that all last-stage aggregations are used.
No graph.dimensions -> use breakouts.
snoe added a commit that referenced this issue May 21, 2024
* [Metrics V2] Backfill viz settings for compatible-series

Fixes #42575

The BE should rely on the query when there is no corresponding viz setting.
If there is no graph.metrics setting, assume that all last-stage aggregations are used.
No graph.dimensions -> use breakouts.

* Fix tests

* Unskip e2e test

---------

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
oisincoveney pushed a commit that referenced this issue May 22, 2024
* [Metrics V2] Backfill viz settings for compatible-series

Fixes #42575

The BE should rely on the query when there is no corresponding viz setting.
If there is no graph.metrics setting, assume that all last-stage aggregations are used.
No graph.dimensions -> use breakouts.

* Fix tests

* Unskip e2e test

---------

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants