Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalculateSkips throws an exception for a year long period #870

Open
rrusso2007 opened this issue Jan 19, 2018 · 0 comments
Open

CalculateSkips throws an exception for a year long period #870

rrusso2007 opened this issue Jan 19, 2018 · 0 comments

Comments

@rrusso2007
Copy link

Calculate skips throws an exception when the period is exactly N years and 0 months since currently only period with months >= 0 goes through this logic when it should be months or years > 0. I have created a pull request with the fix and a test case at:

#869

@rrusso2007 rrusso2007 changed the title CalculateSkips throws an except for a year long period CalculateSkips throws an exception for a year long period Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant