Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog] Inconsistent Background Color in Pop-up: Left Side Does Not Extend to Full Height #1637

Closed
ayush844 opened this issue Feb 12, 2024 · 8 comments
Assignees

Comments

@ayush844
Copy link

Name: For All Patterns
Type: -
Compatibility: -
Pattern ID: -
image:
WhatsApp Image 2024-02-12 at 16 21 09

Description: The pop-up on the catalog section, showing info about different patterns, have some inconsistency in design. The left side, with a dark background doesn't reach all the way down. It changes to a lighter color at the bottom, which looks weird.

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

Copy link

welcome bot commented Feb 12, 2024

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.

@ayush844
Copy link
Author

i am ready to work on this issue, you can assign it to me

@ayush844
Copy link
Author

it'll work fine, if we change height of .modal-image to 103.25%

Screenshot from 2024-02-14 08-21-21

@ayush844
Copy link
Author

hey @ritiksaxena124, please review this PR

Copy link

stale bot commented Apr 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 25, 2024
@leecalcote
Copy link
Member

@abhishekmmgn will you evaluate as to whether this is still outstanding?

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Apr 25, 2024
@abhishekmmgn
Copy link
Member

Because this PR has not been merged

@iArchitSharma
Copy link
Contributor

As this issue is already fixed with this - #1705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment