Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to run tfnotify locally #35

Closed
wants to merge 1 commit into from
Closed

Support to run tfnotify locally #35

wants to merge 1 commit into from

Conversation

babarot
Copy link
Contributor

@babarot babarot commented Apr 12, 2019

WHAT

Add --pr flag and new acceptable value "local" for --ci.

WHY

Fix #4

@babarot babarot requested a review from dtan4 as a code owner April 12, 2019 11:18
@codecov-io
Copy link

Codecov Report

Merging #35 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   89.78%   89.61%   -0.17%     
==========================================
  Files          14       14              
  Lines         548      549       +1     
==========================================
  Hits          492      492              
- Misses         29       30       +1     
  Partials       27       27
Impacted Files Coverage Δ
config/config.go 98.36% <0%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189a71f...1e25d7a. Read the comment docs.

@dtan4
Copy link
Member

dtan4 commented Apr 12, 2019

[IMO] or --ci "none" because this feature enables to run tfnotify "without CI".

@babarot
Copy link
Contributor Author

babarot commented Oct 8, 2019

Closing once because of being stale.

@babarot babarot closed this Oct 8, 2019
@babarot babarot deleted the fix-4 branch October 8, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to use this tool on local machine?
3 participants