Adds properties on edges #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejtonev
requested review from
Josipmrden,
katarinasupe,
as51340 and
antepusic
as code owners
andrejtonev
force-pushed
the
properties_on_edges
branch
from
5b5b266
to
04f29e3
Compare
antepusic
requested changes
Feb 29, 2024
andrejtonev
force-pushed
the
properties_on_edges
branch
from
04f29e3
to
ccc752e
Compare
|
@antepusic I changed the code a bit. Had some CI problems, not sure why it didn't like the first version... |
one_to_many: passing field parameters (which already existed but was not used) many_to_many: changed from parameters to column_names_mapping using the mapping and columns to define properties ignoring from to keys when adding properties
andrejtonev
force-pushed
the
properties_on_edges
branch
from
8451528
to
bd7f510
Compare
antepusic
approved these changes
Mar 11, 2024
Josipmrden
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one_to_many: passing field parameters (which already existed but was not used) many_to_many: changed from parameters to column_names_mapping
using the mapping and columns to define properties
ignoring from to keys when adding properties
Description
Responding to user-made issue. Requesting the ability to define properties on edges.
Something similar was already present, but was not used and needed to be expanded to support mappings.
Mappings are only supported for many_to_many
one_to_many only supports predefined and fixed parameters defined via the configuration file.
Pull request type
Please delete options that are not relevant.
Related issues
Delete section if this PR doesn't resolve any issues.
Closes #301
Checklist:
######################################
Reviewer checklist (the reviewer checks this part)
######################################