Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination for account history + transactions to improve performance #739

Closed
1 of 2 tasks
jakobskrym opened this issue May 11, 2024 · 5 comments
Closed
1 of 2 tasks
Labels
💡 Improvement Improvements to an existing feature or flow ⚡ Performance Performance issues to address

Comments

@jakobskrym
Copy link

Where did this bug occur?

  • Local development
  • Self hosted app (i.e. Docker)

Describe the bug

There is currently no pagination on the account page which means that it becomes very slow to load when you have a higher number of transactions. Wrote a script to import some transactions from my bank (~1.4k) and it made it so slow that I had to restart the app to get to another page.

To Reproduce
Steps to reproduce the behavior:

  1. Ensure >1k transactions or history for given account
  2. Go to account page
  3. Wait

Expected behavior
Use pagination to prevent long loading times.

Screenshots / Recordings
If applicable, add screenshots or short video recordings to help show the bug in more detail.

Additional context
Realize this is in between a bug and a feature request.

@jakobskrym jakobskrym added 🐛 Bug Something isn't working 🚀 Feature labels May 11, 2024
@zachgoll zachgoll added 💡 Improvement Improvements to an existing feature or flow and removed 🐛 Bug Something isn't working 🚀 Feature labels May 14, 2024
@zachgoll zachgoll changed the title Bug: Account page needs pagination for history and transactions to prevent sluggishness Add pagination for account history + transactions to improve performance May 17, 2024
@zachgoll zachgoll added the ⚡ Performance Performance issues to address label May 17, 2024
@jakubkottnauer
Copy link
Contributor

@zachgoll I've tracked down the performance problems to the category dropdown (more specifically the transactions/categories/dropdown/row partial). If I comment out the partial here, account with 1k transactions loads without any problems.

@zachgoll
Copy link
Collaborator

@jakubkottnauer got it, thanks for looking into this. I'm thinking we'll eventually need some pagination since many credit card accounts will have thousands of transactions in a short time-span, but this could be a good temporary fix if we want to make these rows more of a "read only" row for now.

@jakubkottnauer
Copy link
Contributor

@zachgoll I agree we definitely want pagination here to improve the UX. Though I don't think pagination should be used as a bandaid over performance issues - there's no excuse for the page not being able to handle couple of thousands entries, computers are fast enough 😄 In fact, I'll have a PR coming out in a few moments that fixes the perf problems by moving the category menu content into a turbo frame

@zachgoll
Copy link
Collaborator

I think we can close this since #782 drastically improves the performance of large transaction lists.

We can re-introduce pagination as a dedicated feature once we have some designs for it.

@jakobskrym
Copy link
Author

Can confirm it's now much better 👍 Nice work @jakubkottnauer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Improvement Improvements to an existing feature or flow ⚡ Performance Performance issues to address
Projects
None yet
Development

No branches or pull requests

3 participants