Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AUR PKGBUILD #21

Open
mattydebie opened this issue May 22, 2019 · 6 comments
Open

Fix AUR PKGBUILD #21

mattydebie opened this issue May 22, 2019 · 6 comments

Comments

@mattydebie
Copy link
Owner

Now that we depend on lib/helper.sh, we also need to install that to a place on users' filesystem.
Right now we expect the file to be in $PWD/lib/helper.sh which is not the correct place when installing bwmenu to /usr/bin/bwmenu.

@mattydebie
Copy link
Owner Author

renamed lib/helper.sh to lib-bwmenu and added it to install with PKGBUILD for bitwarden-rofi-git.

@Mange
Copy link
Contributor

Mange commented May 22, 2019

I would actually recommend to just inline the file. It's only used in a single place, so I don't see the need to have it in a different file in the first place.

@mattydebie mattydebie reopened this May 23, 2019
@mattydebie
Copy link
Owner Author

That is also a correct assumption 😛

@remyrd
Copy link

remyrd commented May 23, 2019

I created that file because i don't like scrolling :) and it makes the codebase more readable IMO. I'm wondering if it's possible to generate a single file by dereferencing the source commands at install time... no idea if this exists in bash.

@remyrd
Copy link

remyrd commented Jun 17, 2019

Hey guys, just chiming in to let you know this project inspired me to write this https://github.com/remyrd/jimpass over the last few weeks in my free time.

I had many ideas in mind, but keeping everything in a single file and bash would have never been possible. I warmly invite you to take a look at what I did. If you're interested I'll gladly make you contributors or something (not sure what github offers in this regard).

Again, thanks for the inspiration!

@mattydebie
Copy link
Owner Author

That's looking quite good! I also was thinking about using python or go in stead of bash but here we are 😛
Good luck with the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants